w3c / vc-test-suite

Verifiable Credentials WG Test Suite
https://w3c.github.io/vc-test-suite/
BSD 3-Clause "New" or "Revised" License
68 stars 39 forks source link

(editorial) change "Linked Data" to "LD" #77

Open TallTed opened 5 years ago

TallTed commented 5 years ago

"Linked Data Proofs" and "Linked Data Signatures" are referred to as "LD-Proofs" and "LD-Signatures" in the Data Model spec

dmitrizagidulin commented 5 years ago

@TallTed Hehe, though you are right to point out that "LD" matches the spec more, we're kind of stuck with the full "Linked Data" for the moment, especially in that generate.js file, since the only unique identifiers for the test results are their full titles, which include "Linked Data".

dmitrizagidulin commented 5 years ago

Basically, if we change the section names, it's going to throw off test result reporting (until all implementations re-run and re-submit their suites).

TallTed commented 5 years ago

@dmitrizagidulin - Is it possible to quickly sed or similar over all relevant files? This mis-match seems likely to be problematic over time, when people are looking in the implementation report for implementations which reported support for feature X in the spec.

dmitrizagidulin commented 5 years ago

Ah, hmm, that's a good point. Do you mind doing that?

dmitrizagidulin commented 5 years ago

(Though first let me pull in the pending test report PRs)

TallTed commented 5 years ago

@dmitrizagidulin - I can roll through all the files in the w3c/vc-test-suite repo, but my primary (all-but-exclusive) github interface is my web browser, so it will take some time and manual effort. Anyone who works through command-line git will be better equipped to do this.

dmitrizagidulin commented 5 years ago

No worries, I'll do it, then.

TallTed commented 2 years ago

I think that resolves things in the correct way... but some other eyes would be good.

lamjay2704 commented 2 years ago

Thanks