w3c / vc-use-cases

Verifiable Credentials Use Cases
https://w3c.github.io/vc-use-cases/
Other
50 stars 22 forks source link

Repo needs CODEOWNERs #132

Closed OR13 closed 1 year ago

OR13 commented 1 year ago

Make it clear who is required to review.

iherman commented 1 year ago

I can create an empty CODEOWNER file but that is useless. The question is who the code owners are.

Note that @jandrieu, who is probably at least one of the owners, has the right to create such a file, you do not need me for this...

iherman commented 1 year ago

The issue was discussed in a meeting on 2023-02-07

View the transcript #### 1.1. Repo needs CODEOWNERs (issue vc-use-cases#132) _See github issue [vc-use-cases#132](https://github.com/w3c/vc-use-cases/issues/132)._ > *Brent Zundel:* so have an issue - use cases that requires holder binding.
iherman commented 1 year ago

To get things moving, I have added the CODEOWNERS file with a single owner, namely @jandrieu.

@jandrieu, you should modify the file adding the github handles of all the other code owners. At present, the use cases document has 6 editors listed (including you) but I do not know whether all of them should become code owners. I also suspect that Kevin should be added.

jandrieu commented 1 year ago

Thanks, @iherman

I added Kevin @KDean-GS1 the codeowners, but it looks like I also need to give him write privileges for the repo. Tracking how to do that now.

iherman commented 1 year ago

I have invited him to join the separate groups for 'vc contributors', that collect regular contributors to the vc repos. He still has to accept the invitation. This is the simplest way of doing this, securing access to several repositories.

KDean-GS1 commented 1 year ago

@iherman My apologies, I missed the invitation. Please resend as the old one has expired.

iherman commented 1 year ago

@iherman My apologies, I missed the invitation. Please resend as the old one has expired.

Done.

jandrieu commented 1 year ago

@iherman It seems that @KDean-GS1 still can't merge PRs. Is there something more we need to do?

iherman commented 1 year ago

@KDean-GS1 can you try again? Both you and @jandrieu should have "maintain" rights now, which include manipulating PRs.

KDean-GS1 commented 1 year ago

All good now.