search

w3c / vc-use-cases

Verifiable Credentials Use Cases
https://w3c.github.io/vc-use-cases/
Other
50 stars 22 forks source link

Bona fide shopper #145

Closed KDean-GS1 closed 1 year ago

KDean-GS1 commented 1 year ago

This is a follow-on from #127 and replaces that request. Use case proposed by @David-Chadwick.

Preview | Diff

David-Chadwick commented 1 year ago

@KDean-GS1 When I tried to read the Diff, none of the use cases are visible.

TallTed commented 1 year ago

@David-Chadwick — The Diff (and the Preview) are both broken.

This is an issue with the PR-Preview tools. I don't believe @KDean-GS1 can do anything about it.

Try reviewing the source.

jandrieu commented 1 year ago

@David-Chadwick @TallTed I was able to get the preview working by injecting a base for this particular PR.

We'll have to remove that before merging, but at least the preview link should work now.

I've also submitted an issue at the repo for the PR Preview library that is causing this problem: https://github.com/tobie/pr-preview/issues/144

jandrieu commented 1 year ago

This looks great. I'll take the base tag out and then merge.

We can follow up with @David-Chadwick about whether or not we've addressed #127 in that issue.

David-Chadwick commented 1 year ago

Yes its fine with me