search

w3c / vc-use-cases

Verifiable Credentials Use Cases
https://w3c.github.io/vc-use-cases/
Other
50 stars 22 forks source link

GS1 identification use case #151

Closed KDean-GS1 closed 9 months ago

KDean-GS1 commented 1 year ago

Moved and expanded issue #146 into pull request.

:boom: Error: 502 Bad Gateway :boom:

PR Preview failed to build. (Last tried on Feb 2, 2024, 9:49 PM UTC).

More PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [Spec Generator](https://www.w3.org/2015/labs/) - Spec Generator is the web service used to build specs that rely on ReSpec. :link: [Related URL](https://labs.w3.org/spec-generator/?type=respec&url=https%3A%2F%2Fraw.githubusercontent.com%2Fw3c%2Fvc-use-cases%2F9e0951e342562f0027fe609ca84f111ee93eb180%2Findex.html%3FisPreview%3Dtrue) ``` error code: 502 ``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20w3c/vc-use-cases%23151.)._
paulfdietrich commented 1 year ago

@KDean-GS1 I think the GS1 term "key" is going to cause confusion in this context because unless we give a brief definition of what a GS1 key is and that when this section refers to a key it will either use the term GS1 key or cryptographic key.

KDean-GS1 commented 11 months ago

@KDean-GS1 I think the GS1 term "key" is going to cause confusion in this context because unless we give a brief definition of what a GS1 key is and that when this section refers to a key it will either use the term GS1 key or cryptographic key.

I've added a note to the background of the use case.

jandrieu commented 9 months ago

@KDean-GS1 I'm not seeing the updates that resolve my comments.

I'll note that in my own PR, I also had weird problems getting github to show my pushed commits. I pushed to my own fork (without errors on the command-line) but they were not registering. They didn't show in the files I updated, nor did github report that the branch had been updated. It still showed the last commit was two months ago.

I ended up re-cloning my fork and manually bringing the updates over, then adding a new commit.

If you in fact, believe you did respond to my suggestions, that may be the problem.

Please check to see if the files in your fork actually have the edits you think you pushed.