w3c / vibration

Vibration API
https://w3c.github.io/vibration/
Other
12 stars 11 forks source link

Require sticky activation to perform vibrate #30

Closed anssiko closed 2 years ago

anssiko commented 2 years ago

Also:

(Future work: refactor to use the fancier ref syntax.)

Fix #29


Preview | Diff

anssiko commented 2 years ago

PTAL @johannhof

Also, PR Preview integration seems to have a bad day today (Internal Server Error), FYI @xfq

xfq commented 2 years ago

Also, PR Preview integration seems to have a bad day today (Internal Server Error), FYI @xfq

It's tracked in https://github.com/tobie/pr-preview/issues/124

anssiko commented 2 years ago

Re-requesting @rakuco in an attempt to unblock merge.

rakuco commented 2 years ago

It still says At least 1 approving review is required by reviewers with write access here.

anssiko commented 2 years ago

@xfq can you please fix access for @rakuco?

As a spin-off, I’m considering a das-wg-reviewers GH team for known folks for WG-wide reviews, WDYT @reillyeon?

@xfq are GH permissions for W3C repos best practices documented somewhere? https://w3c.github.io/best-practices.html#perms is generic.

johannhof commented 2 years ago

PTAL @johannhof

Apologies, I keep being a bit late on your requests but it looks like @rakuco covered it well. No other comments from me :)

Thanks!

xfq commented 2 years ago

@xfq can you please fix access for @rakuco?

Done.

xfq commented 2 years ago

@xfq are GH permissions for W3C repos best practices documented somewhere? https://w3c.github.io/best-practices.html#perms is generic.

Sorry, not currently available as far as I know. Feel free to file an issue in https://github.com/w3c/w3c.github.io/issues if you have any proposal.

anssiko commented 2 years ago

Thanks @rakuco and @johannhof for your review, and @xfq for the GH permissions fix.