Closed anssiko closed 2 years ago
PTAL @johannhof
Also, PR Preview integration seems to have a bad day today (Internal Server Error), FYI @xfq
Also, PR Preview integration seems to have a bad day today (Internal Server Error), FYI @xfq
It's tracked in https://github.com/tobie/pr-preview/issues/124
Re-requesting @rakuco in an attempt to unblock merge.
It still says At least 1 approving review is required by reviewers with write access here.
@xfq can you please fix access for @rakuco?
As a spin-off, I’m considering a das-wg-reviewers
GH team for known folks for WG-wide reviews, WDYT @reillyeon?
@xfq are GH permissions for W3C repos best practices documented somewhere? https://w3c.github.io/best-practices.html#perms is generic.
PTAL @johannhof
Apologies, I keep being a bit late on your requests but it looks like @rakuco covered it well. No other comments from me :)
Thanks!
@xfq can you please fix access for @rakuco?
Done.
@xfq are GH permissions for W3C repos best practices documented somewhere? https://w3c.github.io/best-practices.html#perms is generic.
Sorry, not currently available as far as I know. Feel free to file an issue in https://github.com/w3c/w3c.github.io/issues if you have any proposal.
Thanks @rakuco and @johannhof for your review, and @xfq for the GH permissions fix.
Also:
(Future work: refactor to use the fancier ref syntax.)
Fix #29
Preview | Diff