w3c / wai-aria-practices

WAI Website Resource for aria-practices guidelines
https://aria-practices.netlify.app/aria/apg/
17 stars 14 forks source link

2 Grid and 2 Landmark pages lead to 404 when accessed via redirects due to casing of file names #192

Closed mcking65 closed 1 year ago

mcking65 commented 1 year ago

We have 4 legacy URLs that still lead to 404 errors.

Data Grids Example Page

because people could be bookmarking the current functional location, it seems like we should change the redirect to point to the functional location. Then, we land Pull Request #2597 and add another redirect to the renamed file.

Layout Grids example page

because people could be bookmarking the current functional location, it seems like we should change the redirect to point to the functional location. Then, we land Pull Request #2597 and add another redirect to the renamed file.

Landmark Examples: HTML Sectioning Elements page

Should we leave the redirect as is and rename content/patterns/landmarks/examples/HTML5.html to content/patterns/landmarks/examples/html5.html? Perhaps add this change to w3c/aria-practices#2597?

Landmark Examples: General Principles page

Is the best solution to change the redirect to point to functional location 1?

@alflennik wrote:

I looked into the datagrids and layout grids a little bit more and found that the WAI website seems to automatically remove capitalized letters from URLs. This is why the links on the site work but bookmarked pages don't.

I think the pages already have a bit of a strange naming convention, given that no other pages have capitalized letters, so a good solution would probably be to rename those two files in the aria-practices repo and introduce new redirects from the old urls to the new ones.

Originally posted by @alflennik in https://github.com/w3c/wai-aria-practices/issues/186#issuecomment-1412195791

a11ydoer commented 1 year ago

@alflennik can you share the order of actions you mentioned at the APG meeting on 2/14/2023?

alflennik commented 1 year ago

@mcking65 @a11ydoer we can safely merge https://github.com/w3c/aria-practices/pull/2597 and following that I will create a new publication branch, inform the WAI team, and document the changes we need to make to the redirects.

alflennik commented 1 year ago

@mcking65 shall we close this issue following the deploy last week?

mcking65 commented 1 year ago

Yes. Closed by w3c/aria-practices#2597 and #200.