w3c / wai-aria-practices

WAI Website Resource for aria-practices guidelines
https://aria-practices.netlify.app/aria/apg/
15 stars 14 forks source link

For publication / deploy on Wednesday April 12 or Thursday April 13 (see comments for date determination) #210

Closed alflennik closed 1 year ago

alflennik commented 1 year ago

Hi @shawna-slh, we would like to deploy a new version of APG.

Changes include:

netlify[bot] commented 1 year ago

Deploy Preview for aria-practices ready!

Name Link
Latest commit 0d8fb80e2065bf2da457e842b50e21b71a89b13f
Latest deploy log https://app.netlify.com/sites/aria-practices/deploys/6438180c1fb6b20008ad2ec6
Deploy Preview https://deploy-preview-210--aria-practices.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mcking65 commented 1 year ago

@shawna-slh

Per discussion in WAICC, we still have a couple of items to line up for the announcement. We can deploy ahead of the announcement, but I hope no more than two days before.

We need to deploy this week if we are to have Alex or Howard available to support it in the event something goes sideways.

mcking65 commented 1 year ago

@alflennik

I would like to include w3c/aria-practices#2558. It appears it is on track for merge in the morning. I am waiting on one more review.

shawna-slh commented 1 year ago

I will hold off on publication, as there are a few things that need to be addressed. I understand we would like to publish today or Wednesday possible.

(ping @daniel-montalvo to see this pull request :-)

shawna-slh commented 1 year ago

Hi @alflennik @mcking65 @a11ydoer @daniel-montalvo I'm not seeing the tables in the preview. Shouldn't one be in https://deploy-preview-210--aria-practices.netlify.app/aria/apg/patterns/button/examples/button/ ?

alflennik commented 1 year ago

@shawna-slh I do see it in the assistive technology support section, it's the last heading on the page, here's a screenshot of what I'm seeing:

Assistive Technology support section with support tables loaded
alflennik commented 1 year ago

@shawna-slh assuming my comment cleared things up, we are ready to release!

cc @mcking65 @a11ydoer

shawna-slh commented 1 year ago

Ah, I was looking for it in the Page Contents box -- and with my configuration, I don't see it: image

even when I scroll down: image

So that's a separate issue. I'll leave it to you all to create an Issue for that.

daniel-montalvo commented 1 year ago

Hi @alflennik @mcking65 Ideally we can fix https://github.com/w3c/aria-practices/issues/2650 soonish.

I would expect these pages to get more traction given the imminent blog announcement. Even if it is not related to AT support tables, it seems to me that having an example that lacks visual focus indication is problematic and can raise some eyebrows. If I am not mistaking, the button examples are one of the four that will have the new tables, so that is yet another reason for people to look specifically at this pages. I would suggest we prioritize this.

alflennik commented 1 year ago

@shawna-slh thank you for sharing the screenshot, I can see that in your setup the page contents navigation box is so tall it's clipping off the bottom of the screen. The part that especially gives me pause is that the links in the box are wrapping so much, for example the "Role, Property, State and Tabindex Attributes" link is wrapped over four lines. I tried a few ways to reproduce this issue, including changing the default text size, but I couldn't get that amount of wrapping to occur.

Looking at your screenshots I can see that there might be some custom css styles applied to the site. Would you mind checking if the issue still occurs without the styles present? Also would it be possible to let me know what your default text size is?

alflennik commented 1 year ago

Hi @daniel-montalvo, thank you for emphasizing the importance of the button focus issue, I agree that it's an eyebrow raiser. I opened a PR here: https://github.com/w3c/aria-practices/pull/2673 and, pending review, the fix should be in the next release.

mcking65 commented 1 year ago

@alflennik, with w3c/aria-practices#2673 merged, should we try to include it in this PR before the publication?

alflennik commented 1 year ago

@mcking65 I updated the PR with the typo fix and the button focus indicator fix, I'm glad we had a chance to fix those.

shawna-slh commented 1 year ago

@mcking65 @alflennik @a11ydoer

It looks like we'll get the blog issues worked out. Shall I publish this now, while Alex is available to QA it?

mcking65 commented 1 year ago

@shawna-slh Yes, we are on track for Monday announcement, so let's please push this to production.

mcking65 commented 1 year ago

Thank you @alflennik for getting those latest 2 fixes included in this PR.

shawna-slh commented 1 year ago

Deployed. I did a just few quick checks, and looks good. Others please do more thorough QA. Thanks.

alflennik commented 1 year ago

Thank you @shawna-slh! I confirmed that the support tables are working.

mcking65 commented 1 year ago

Thank you @shawna-slh!!!

I went through all the changed pages since last deploy and spot checked some other places, and from the POV of a screen reader user, it looks great! I hope the same is true visually! Would be good for someone to double-check the fix to focus indicator on button example page.

alflennik commented 1 year ago

@mcking65 I confirmed that the button indicator is working.