search

w3c / wai-aria-practices

WAI Website Resource for aria-practices guidelines
https://aria-practices.netlify.app/aria/apg/
17 stars 14 forks source link

[AT support sections] use existing design pattern for expandable warning box [was: affordance of expand] #212

Closed shawna-slh closed 4 months ago

shawna-slh commented 1 year ago

I missed that the "Warning! Unapproved Report" was expandable to reveal more information.

Is there a reason not use the same UI design, interaction, code, etc. as the "Read This First" expandable warning box at the top of the pages? example

mcking65 commented 1 year ago

Visually, what is the disclosure missing that it should have? I can't tell the difference as a screen reader users. Both are appropriately marked up.

shawna-slh commented 1 year ago

I updated the issue title and my initial comment to more clearly ask if there is a reason not to use the current design pattern.

mcking65 commented 1 year ago

@isaacdurazo Please comment on this

isaacdurazo commented 1 year ago

When we designed the mockups for the embedded reports, the intention was to have a section above the table that displayed information about the report being generated from candidate tests. It was not a disclosure nor a warning message.

The original design was:

  1. A heading that reads "Candidate Report" with the same visual label style we use in ARIA AT. This now reads "Warning! Unapproved Report", but still has the label style.
  2. A paragraph that reads:
    • The information in this report is generated from candidate tests. Candidate aria-at tests are in review by assistive technology developers and lack consensus regarding:
      • applicability and validity of the tests, and
      • accuracy of test results.

I'm not sure at what point this design changed during implementation, but I think we should either make it look like the existing "Read This First" disclosure or make it so the content is always visible.

I'm also noticing the font size is smaller than the rest, so it might be a good opportunity to fix that as well.

ccanash commented 1 year ago

Thank you Isaac . @mcking65 Let me know if we should prioratize this. We could tackle it while we unblock some items from the refactor project.

ccanash commented 4 months ago

HI @mcking65 , a preview of this PR has been deployed here: https://aria-at-app-sandbox.bocoup.com/embed/reports/modal-dialog

ccanash commented 4 months ago

Closing at this has been released to production