w3c / wai-aria-practices

WAI Website Resource for aria-practices guidelines
https://aria-practices.netlify.app/aria/apg/
15 stars 14 forks source link

PRs triggered by aria-practices falling out of sync #219

Open howard-e opened 1 year ago

howard-e commented 1 year ago

This was recently observed in https://github.com/w3c/aria-practices/pull/2622#issuecomment-1525940506, where the following error was being surfaced:

Error: > /home/runner/work/wai-aria-practices/wai-aria-practices/scripts/pre-build/library/determineContentType.js:48 throw new Error( ^ Error: Could not determine content type for file at /home/runner/work/wai-aria-practices/wai-aria-practices/_external/aria-practices/content/about/introduction/introduction.html This file may not follow established conventions.

The pr-create.yml seems to be missing a crucial step in ensuring the generated PR in this repository is rebased onto the default branch before regenerating the preview.

This hasn't been an issue in the past mainly because of the typically static and unrelated nature of the content and utilities. Also of assistance, was how GitHub's default updating of an existing PR works when the default branch is updated. But in this instance (and others), wai-aria-practices has undergone many changes which were not properly accounted for.

Exploring automatic rebases when the script runs (or exploring manual but assisted triggers such as actions/automatic-rebase) should be considered.

howard-e commented 1 week ago

Wiki page on how to manually fix for now