Closed alflennik closed 6 months ago
Name | Link |
---|---|
Latest commit | de939dde6b55d66f4f67dded012a97a154f1fa79 |
Latest deploy log | https://app.netlify.com/sites/aria-practices/deploys/6578a06a1e702d00089a55c2 |
Deploy Preview | https://deploy-preview-281--aria-practices.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@alflennik This is a partial fix, and it is a good step forward.
However, waht we'd ultimately like is quite a bit more complicated. The last changed date should be the date of last change for any of the HTML, CSS, or JS that are specific to the example. We only want to consider the files specific to the example, not any of the shared CSS or JS.
For example, for the select-only combox example, we would want to show the date of most recent change for any of the following files in the content/patterns/combobox/examples
directory:
@mcking65 the date now reflects all the CSS and JS files! @howard-e this is ready for review again.
Fantastic, thank you @alflennik.
The example pages include the date that the example last changed, which is sourced from the git history. However in CI builds of the site, the last modified date ends up being the date the build was last done.
The cause seems to be that GitHub Actions uses a shallow clone instead of a full clone with the complete history.
We won't know for sure if this is solution until we merge this PR to main and the offending action runs.
See https://github.com/w3c/wai-aria-practices/issues/255.