search

w3c / wai-aria-practices

WAI Website Resource for aria-practices guidelines
https://aria-practices.netlify.app/aria/apg/
15 stars 14 forks source link

For publication / deploy on Tuesday December 12, 2023 #284

Closed howard-e closed 6 months ago

howard-e commented 6 months ago

Hi @shawna-slh. We would like to deploy a new version of the APG as requested by @mcking65 through a recent email thread.

The update includes the following, as sourced from the October 24, 2023 and December 11, 2023 w3c#aria-practices commits:

Landmark Practice: Add note to prevent dialog content wrapped in a landmark (pull #2818)

By mcking65 on Oct 24, 2023

Resolve issue #2512 by adding the following note to principles of landmark design:

Note that wrapping the content of a modal dialog in a landmark region is unnecessary. A landmark that wraps modal content cannot provide any benefit to users because it is not perceivable unless the modal is open. In addition, when a modal is open, a landmark containing its content is superfluous because the modal itself is a container that provides both a name and boundaries.

View commit eed124a

Infrastructure: Use aria-practices repo as source for images, patterns.html, and practices.html (pull #2869)

By alflennik on Dec 11, 2023

Resolve issue 2702 by moving HTML content and images from the wai-aria-practices repo into the aria-practices repo. This includes HTML content for the patterns.html page, the practices.html page, and images across all patterns and examples. A complementary change is made to the build process in the wai-aria-practices repo via PR w3c/wai-aria-practices#280.

View commit 4bb1946

Infrastructure: Source heading for read this first content from aria-practices repo (pull #2867)

By Paul-Clue on Dec 11, 2023

Moves the h2 element that is part of the "Read This First" content from the wai-aria-practices repo into the aria-practices repo. This is part of an effort to ensure all content is sourced and controlled from the aria-practices repo and the wai-aria-practices repo provides only transformations necessary for site build.

View commit 4a3531f

Modal Dialog Example: Increase z-index of dialog backdrop (pull #2843)

By emamoah on Dec 11, 2023

Resolves issue 2842: A CSS bug where part of the modal dialog popup was obscured on some small screens.

View commit d057791

netlify[bot] commented 6 months ago

Deploy Preview for aria-practices ready!

Name Link
Latest commit cf6ce2c8f37f51bf07a2b8a9fe18a2a7933a4e3c
Latest deploy log https://app.netlify.com/sites/aria-practices/deploys/6577b611d92c6a000870b84b
Deploy Preview https://deploy-preview-284--aria-practices.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

howard-e commented 6 months ago

cc @mcking65 @a11ydoer @ccanash

shawna-slh commented 6 months ago

published/deployed.

Thank you for the clear info on the changes in the PR!

mcking65 commented 6 months ago

Thank you @shawna-slh!!

@a11ydoer @howard-e

Please survey the production site to ensure image presentation is as expected across patterns, examples, and practices. I will verify the other changes.

mcking65 commented 6 months ago

I have verified the changes that I can .... I can't test the z index change to modal dialog. @a11ydoer, could you do that please?

a11ydoer commented 6 months ago

@mcking65 Z index looks good. However, there are two same h2, "Read This First" in the dialog modal page. Two H2 headings are present on all the Patterns example pages.