w3c / wai-aria-practices

WAI Website Resource for aria-practices guidelines
https://aria-practices.netlify.app/aria/apg/
15 stars 14 forks source link

For publication / deploy on Tuesday May 28, 2024 #327

Closed howard-e closed 1 month ago

howard-e commented 1 month ago

We would like to deploy a new version of the APG. This was approved during the May 21, 2024 APG meeting and during a recent email thread with @mcking65.

The update includes the following, as sourced from the 2024-05-23 APG Publication Pull Requests milestones and recent w3c#aria-practices commits to main:

About: Add page to about section that explains the AT support tables (pull #3000)

By Matt King on May 22, 2024

Co-authored-by: Boaz Sender

View commit 2e21c92


Feed Example: Move display of example from separate page into standard APG example page (pull #2775)

By Ariella Gilmore on May 22, 2024

Enables the feed example to be displayed inline within the feed example page using an iframe. Previously, the example had to be opened in a separate page.

Also includes some editorial revisions and updates.

Co-authored-by: Andrea N. Cardona Co-authored-by: Matt King Co-authored-by: Mike Pennisi Co-authored-by: Howard Edwards

View commit 0e40c0d


Infrastructure: Update skipto.js to fix shortcut key bug for non-english keyboard layouts (pull #2975)

By Jon Gunderson on May 22, 2024

View commit 504391a

netlify[bot] commented 1 month ago

Deploy Preview for aria-practices ready!

Name Link
Latest commit e2b1d1832e5628cb153f5bc1fc08a83b049b62d3
Latest deploy log https://app.netlify.com/sites/aria-practices/deploys/664f6c0bf7333400087848c3
Deploy Preview https://deploy-preview-327--aria-practices.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

howard-e commented 1 month ago

Drafting until confirmation can be had on https://github.com/w3c/aria-practices/pull/3026 being ready for today's publication.

howard-e commented 1 month ago

@shawna-slh is there a cut off time for when you could perform the publication?

shawna-slh commented 1 month ago

If it is simple content updates, then I can do until 4:30pmCT. If there are potentially problematic things that might break the site deploy, I'd be hesitant to do after 12:00noonCT since Remi will be done for the day.

NOTE: For timely communications, please ping me in Slack (or IRC or WhatsApp or text) as I won't see e-mail notifications of comments here right away.

howard-e commented 1 month ago

If it is simple content updates, then I can do until 4:30pmCT. If there are potentially problematic things that might break the site deploy, I'd be hesitant to do after 12:00noonCT since Remi will be done for the day.

Yep, this PR does contain only simple content updates. 1 additional page has been added but it follows the pattern of other similar pages in the About section, so it should raise no issues. And the incoming change being requested here only affects a single existing file as well.

cc @mcking65 @a11ydoer on the above time constraints if we would like to still include https://github.com/w3c/aria-practices/pull/3026 today.

NOTE: For timely communications, please ping me in Slack (or IRC or WhatsApp or text) as I won't see e-mail notifications of comments here right away.

Thank you for the reminder, will do!

mcking65 commented 1 month ago

@shawna-slh

Offline, we just started a discussion about whether to wait till Tuesday b/c of timing of AT support table update dependencies on the aria-at side.

mcking65 commented 1 month ago

I merged w3c/aria-practices#3026

howard-e commented 1 month ago

Offline, we just started a discussion about whether to wait till Tuesday b/c of timing of AT support table update dependencies on the aria-at side.

@mcking65 @shawna-slh I've updated the description of this PR to be a May 28 deploy request instead.

I merged https://github.com/w3c/aria-practices/pull/3026

Thanks!

shawna-slh commented 1 month ago

@howard-e This is currently set as draft. Is it ready for deploy/publication?

howard-e commented 1 month ago

Offline, we just started a discussion about whether to wait till Tuesday b/c of timing of AT support table update dependencies on the aria-at side.

@mcking65 @a11ydoer the blocking deploy on the aria-at-app has now been done.

This is currently set as draft. Is it ready for deploy/publication?

@shawna-slh thanks for checking in! I've now marked this ready for publication.

shawna-slh commented 1 month ago

@remibetin - ready to publish. Thanks!

a11ydoer commented 1 month ago

@remibetin, please let me know if it has been published so I can confirm the changes. @mcking65

remibetin commented 1 month ago

@a11ydoer I will publish in the next 30min.

remibetin commented 1 month ago

@a11ydoer @mcking65 @howard-e These changes have been published!

cc @shawna-slh

howard-e commented 1 month ago

Thanks @remibetin!