search

w3c / wai-aria-practices

WAI Website Resource for aria-practices guidelines
https://aria-practices.netlify.app/aria/apg/
17 stars 14 forks source link

case redirect not working #91

Closed michael-n-cooper closed 2 years ago

michael-n-cooper commented 2 years ago

As I mentioned in #37, I expect the case-sensitive URI for the APG to be https://www.w3.org/WAI/ARIA/apg/ which puts it under the grandfathered uppercase /WAI/ARIA/ but uses the required lowercase for the new resource. There is a redirect that causes URIs like /wai/aria/ or /WAI/aria/ to redirect to /WAI/ARIA/. But that redirect is not working for this resource, it seems to have been deployed in a manner that bypasses the redirect, so the only case-sensitive URI that works is https://www.w3.org/WAI/aria/apg/. I think it either needs to be under the existing redirect system, or do its own redirecting to make sure that URIs with other cases still wind up at the canonical URI.

shawna-slh commented 2 years ago

Hopefully @SteveALee can shed some light on what happened with the capitalization. I'm afraid it's an issue with the site publication system. I'm not sure the challenges with changing that.

I can do individual redirects, yet need W3C Systems Team to do more. I'll wait for Michael and Steve to help figure out best way to address that.

SteveALee commented 2 years ago

There is no specific redirection going on. Except for the Netlify previews which annoyingly change everything to lowercase, at least in the address bar.

Looking at the published pages in the gih-pages branch they all use aria/apg. I expect that would explain the issue and they should appear at ARIA/apg (cif WCAG2/supplemental)

I did mention that I thought all permalinks should be be ARIA/apg and I take your comments above to confirm that is the case.

So all occurrences need to change:

  1. the permalink and ref in each page
  2. the permalink and ref for the examples html files
  3. config.yml file in wai-website (and also the apg repo for consistency)
  4. netlify.toml
  5. any more?

I'll do 3 ready for today's publication, but the rest need doing too by the APG team.

SteveALee commented 2 years ago

@shawna-slh FYI I updated the wai-website _config.yml so any publication now will have updated links in the ARIA/apg page header and nav. Until the other changes are made this will result in 404s (now ARIA instead of aria)

shawna-slh commented 2 years ago

@alflennik @richnoah @michael-n-cooper

Please confirm that indeed we want to and can correct the URI capitalization today?

alflennik commented 2 years ago

@shawna-slh We changed the capitalization of the code in the wai-aria-practices repo so it is now consistent with the expected state when deployed.

shawna-slh commented 2 years ago

@SteveALee Most of it is working -- from https://www.w3.org/WAI/ARIA/apg/

However, all of the examples are 404, e.g, https://www.w3.org/WAI/ARIA/apg/example-index/ and https://www.w3.org/WAI/ARIA/apg/example-index/alert/alert because the example-index folder is missing from https://github.com/w3c/wai-website/tree/gh-pages/ARIA/apg

The example-index folder was there last Friday: https://github.com/w3c/wai-website/tree/ec6d9146d33dbf62d86b603458cb7d757a5e2d73/aria/apg

We looked over the changes you made: https://github.com/w3c/wai-website/commits/master We tried updating the symlink: https://github.com/w3c/wai-website/commit/667dc7cb5954f12e0446d8a3bfc5cb73397b38ad

We couldn’t figure it out.

Some more info in e-mail.

richnoah commented 2 years ago

@SteveALee I will be available at approximately 8am BST, 2am CDT, on IRC #aria-apg to answer any questions or provide any assistance.

The missing example-index folder is also impacting the delivery of a Jump To as described in Issue 89

mcking65 commented 2 years ago

I am most confused that yesterday the URI resolution was not case sensitive. In a browser address field, you could type w3.org/wai/aria/apg and the URI would resolve successfully and show the site. Since the most recent deploy, if you don't have WAI and ARIA in all caps when typing the address in a browser, the URI yields a 404 for all pages across the site.

So, fixing the example page 404's is top priority, but we also need to fix the broader case sensitivity regression so that browser address input is not treated in a case sensitive manner. Judging from how Michael wrote the issue, I am assuming this is in scope.

SteveALee commented 2 years ago

We tried updating the symlink: https://github.com/w3c/wai-website/commit/667dc7cb5954f12e0446d8a3bfc5cb73397b38ad

That was the correct thing to do (sorry I forgot about mentioning that). However the link was corrupted with extra junk on the end of the target. I guess editing the "file" for symblinks in GitHub doesn't work, assuming that is whgat you did. I've always done it locally using the ln -s command.

I would would expected the build to have thrown an error - "but not a squeak" :(.

Anyway is now fixed and release is running so hopefully still good for GAAD!?

SteveALee commented 2 years ago

@mcking65 I am also confused. You should always have used /ARIA/apg as URIs are case sensitive and that is what Shawn wanted.

I do not understand what the new w3c case conversion redirection does that @michael-n-cooper mentions at the top of this issue.

Hopefully it is now as required. But if /aria/apg is now supposed to work and does not I guess we have more work to do. Shawn and I need to better understand how it supposed to work so we can figure out what might be breaking it.

Does WCAG\supplemental work as expected - that should be have the same as far as I am concerned.

@michael-n-cooper can you please advise?

richnoah commented 2 years ago

Hello, @SteveALee thank you for the assistance. Confirming that the site is back up. I also can confirm that the case redirect is not working as I understood it to work.

SteveALee commented 2 years ago

@richnoah Excellent.

What are the plans for GaaD? Are they still on track?

We need Michael to clue us in re redirects.

SteveALee commented 2 years ago

@mcking65 Double checking and https://www.w3.org/WAI/ARIA/apg/example-index/ is good!

SteveALee commented 2 years ago

@michael-n-cooper is it possible the reverse proxy for /WAI is breaking the case redirection logic on the w3c side? I can see nothing unusual about the way the site is served from the gh-pages branch of wai-website repo.

richnoah commented 2 years ago

as an update I was just able to get https://www.w3.org/wai/aria/apg/ to work and it resolved to https://www.w3.org/WAI/ARIA/apg/. I tried this on both Chrome and Safari. @SteveALee

SteveALee commented 2 years ago

Yay. So the fix was as per the original message in this issue. Closing :)