[delete now that replaced?] Add evaluation videos to overview

w3c / wai-eval-overview

5 stars 33 forks source link

[delete now that replaced?] Add evaluation videos to overview #17

Closed hidde closed 4 years ago

hidde commented 4 years ago

@slhenry @nitedog Ready for your review: the first overview page with:

first video player is AblePlayer with link to transcript
other video players are regular <video> elements with link to page with more accessible version

Captions are missing, as I did not receive .vtt files yet.

Preview

netlify[bot] commented 4 years ago

Deploy preview for wai-eval-overview ready!

Built with commit a3ac92b29f4a1c63e982031fdcb520d650378cb1

https://deploy-preview-17--wai-eval-overview.netlify.com

shawna-slh commented 4 years ago

Hi Hidde! Great to see this coming along. A few things I noticed on quick skim (might see more when review more thoroughly):

[ ] I'm not getting the AblePlayer controls (first video)
[x] The links underneath the other videos should go directly to the video on that page. i.e., on the Tools Overview and Conformance Overview, that should be be the H1. And for the others, the new H2.
[x] footer updates missing

hidde commented 4 years ago

Issue from Shawn that describes how to include text transcript: https://github.com/w3c/wai-eval-overview/issues/19

hidde commented 4 years ago

Information about footers:

[[
<p>Developed with input from the Education and Outreach Working Group (<a href="http://www.w3.org/WAI/EO/">EOWG</a>).</p>
'']]

to:
[[
<p>Videos developed by the Education and Outreach Working Group (<a href="http://www.w3.org/WAI/EO/">EOWG</a>) with support from the <a href="https://www.w3.org/WAI/about/projects/wai-guide/">WAI-Guide</a> project funded by the European Commission (EC) under the Horizon 2020 program (Grant Agreement 822245). <a href="@@">Acknowledgments</a>.</p>
'']]

and update date:
[[
<p><strong>Date:</strong> Updated 00 March 2020.</p>
]]

hidde commented 4 years ago

Updates:

AblePlayer controls: the controls did not render, because the caption file I linked does not yet exist, have removed captions from now
Updated footer text
To first video, added a link to newly created alternatives section, per @slhenry's suggestions

shawna-slh commented 4 years ago

Since this is under hidde: instead of w3c: , I couldn't work with it directly. So I did another pull request

https://github.com/w3c/wai-eval-overview/pull/21

I assume close this one?

hidde commented 4 years ago

@slhenry Thanks, closing this as it now exists as #21