Closed 3l3gant-cod3s closed 8 months ago
remibetin
commented
8 months ago @3l3gant-cod3s Concerning hreflang, I think it is best to not add them manually. I have created an issue and will investigate soon: https://github.com/w3c/wai-translations/issues/161
Concerning link text still in English, would you be willing to translate them?
3l3gant-cod3s
commented
8 months ago Hi @remibetin Because I thought the translation was complete I had a very wrong mental model of why some link's texts weren't translated: that no (linked) translation existed. Despite the fact that they weren't marked as English portions of text (with an lang="en" attribute), a discrepancy which should have alerted me. Like these ones: https://www.w3.org/WAI/people-use-web/user-stories/fr#sections-lies--lee
Principes d’accessibilité
So I wrongly reused the logic used elsewhere: adding hreflang@en and lang@en. I think now that it wasn't the right think to do (sorry). I will soon push French translations of all the links and remove hreflang@en and lang@en attributes.
3l3gant-cod3s
commented
8 months ago So please do not merge now :)
3l3gant-cod3s
commented
8 months ago Now I do have a Stylus CSS rule overload which highlights the English portions of text so the discrepancy is self-evident as the “English” links aren’t highlighted… :/
3l3gant-cod3s
commented
8 months ago I didn't notice the absence of “(en anglais)”, either
3l3gant-cod3s
commented
8 months ago replaced by #319
3l3gant-cod3s
commented
8 months ago ping @remibetin
✅ Deploy Preview for wai-people-use-web ready!
Toggle QR Code...
Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site configuration.