w3c / wai-people-use-web

25 stars 60 forks source link

[ French ] rollback: hreflang+lang + English text links translated to French – Update user-stories.fr.md #319

Closed 3l3gant-cod3s closed 6 months ago

netlify[bot] commented 8 months ago

Deploy Preview for wai-people-use-web ready!

Name Link
Latest commit
Latest deploy log https://app.netlify.com/sites/wai-people-use-web/deploys/65a937ff677b8614c165e4b1
Deploy Preview https://deploy-preview-319--wai-people-use-web.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

3l3gant-cod3s commented 8 months ago

@remibetin I made the link’s missing translation. But there's no menu and the automatic conversions of the links doesn't work on Netlify: https://deploy-preview-319--wai-people-use-web.netlify.app/people-use-web/user-stories/fr cf the “(en anglais)” addition :( There is a brand new (and more detailed) menu for the section, too: https://deploy-preview-319--wai-people-use-web.netlify.app/people-use-web/fr Perhaps the source of the problem? (global restructuration of the section?) cf https://github.com/w3c/wai-people-use-web/blob/master/_data/navigation.yml#L81 Please do whatever you think is appropriate (closing this PR…): I can quite easily reapply these updates, even on a bunch of files (cf user-stories-one…nine) instead of a single file (cf user-stories.fr.md). Because I scripted them (with sed).

remibetin commented 8 months ago

@3l3gant-cod3s Thanks for the update!

But there's no menu and the automatic conversions of the links doesn't work on Netlify

You can ignore these two "issues". They only concern previews in this repo. The content will be properly displayed on live website.

I made the link’s missing translation.

Thanks! I will review them as soon as possible.

remibetin commented 7 months ago

@3l3gant-cod3s Thanks!

I see "Sections related to Kaseem" is not translated. Could you translate it and add it to the PR?

Also, please update the last_updated date since new items have been translated.