w3c / wai-website

This repository hosts the WAI Website.
https://www.w3.org/WAI/
Other
46 stars 153 forks source link

Excludes APG Landmark Examples Pages from site search #362

Open howard-e opened 9 months ago

howard-e commented 9 months ago

Fix for #357 by excluding the following pages from the site search:

I followed jekyll-tipue-search's README on doing the exclusions.

@shawna-slh please let me know if how the paths to the files are defined is okay. I verified locally with my wai-website build that all 12 pages are excluded from the site search.

netlify[bot] commented 9 months ago

Deploy Preview for wai-website ready!

Name Link
Latest commit 69e58785bffa9423487d09269127cb21b9410196
Latest deploy log https://app.netlify.com/sites/wai-website/deploys/662a01ecaade93000839d0f0
Deploy Preview https://deploy-preview-362--wai-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

howard-e commented 9 months ago

cc @yatil

@mcking65 if this change lands, note that the links in the top comment will be excluded from the WAI website's site-wide search. https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/ will still be searchable which also links to these pages.

My comment on why is here: https://github.com/w3c/wai-website/pull/358#issuecomment-1745643393

shawna-slh commented 9 months ago

Thanks. We're having issues with the site build and need to do important updates tomorrow, Thursday. Then y'all are off Friday. And I'm traveling for the next 2 weeks. I'll see if there's a time we can coordinate an update. Otherwise, it will be later in October.

howard-e commented 9 months ago

And I'm traveling for the next 2 weeks.

Safe travels!

I'll see if there's a time we can coordinate an update. Otherwise, it will be later in October.

Okay understood. I'll also be off Oct 16 - 30 as well, so you can check in with @ccanash for support if I'm not available when you're back.

shawna-slh commented 1 month ago

@remibetin Thank you for following up on this!