Closed shawna-slh closed 6 years ago
Reason for indentation: It is in our grid. Happy to change
Yes, please. :)
When we use bold font for DT by default, we lose the possibility to do that.
um - can't we override it? I think we want most DTs to be bold. Therefore, I think we want bold the default in the main CSS. Agree that we might want some DTs not bold. Let's discuss if needed.
Consider spacing. Probably add class for more space between items...
um - can't we override it? I think we want most DTs to be bold. Therefore, I think we want bold the default in the main CSS. Agree that we might want some DTs not bold. Let's discuss if needed.
It’s easier and more semantic to say <dt><strong>This is a dt that should be strong</strong></dt>
instead of having a class that says <dt class="thisdtisnotthatimportant"></dt>
. However, no need for discussion.
Consider spacing. Probably add class for more space between items...
Spacing was considered. I don’t want to add too many styles for fringe use cases because it clutters our CSS and we have to constantly look it up.
Please tell me what space you want around what or point me to a page where you like the spacing and all variants and I’ll put that into our styleguide.
Uh, I should have looked at your first screenshot where the <dt>
s actually are bold.
I think we want <dd>s to have less indent. Here's what I'm seeing now:
compare to current site - which works better for some people low vision and some cognitive abilities:
Also, I think we want our default style is <dt>s are bold. (I think that's in another issue somewhere?)