search

w3c / wcag-redesign

Temporary repository to preview WCAG redesign work
0 stars 1 forks source link

[Index pages & About pages] space above h1 #21

Closed shawna-slh closed 2 years ago

shawna-slh commented 2 years ago

For Understanding and Techniques index and about pages, add space above the H1

Here's the CSS from About Supplemental Guidance

}
h1, h1+h2 {
    margin-top: 0;
}
h1 {
    line-height: 1.2;
    font-weight: 400;
}
h1 {
    font-size: 24px;
    font-size: 1.5rem;
}
h1, h2, h3, h4 {
    color: #005a6a;
    color: var(--wai-green);
}
h1, h2 {
    margin: 60px 0 20px;
}
h1, h2, h3, h4, h5, h6 {
    padding: 0;
}
michael-n-cooper commented 2 years ago

While I can put the above CSS into the local CSS, it is better to load whatever WAI CSS you want to load that includes that. I need the URI to that.

SteveALee commented 2 years ago

I think this should be bottom margin of nav above

SteveALee commented 2 years ago

fixed in #27

shawna-slh commented 2 years ago

Hey @SteveALee

I'm still getting h1 squished up against the pager: image

@1:30pmCT In Vivaldi and in FireFox

shawna-slh commented 2 years ago

Steve, I moved this to Milestone Level 4, since seems it's not so easy afterall :-/

SteveALee commented 2 years ago

Will check its notvanything silly/obvious as bowser specific behaviour is uncommon these days.

SteveALee commented 2 years ago

now fixed in #27 - seems a change got reverted

shawna-slh commented 2 years ago

Hey @SteveALee after discussion with EOWG, I am proposing (for confirmation once folks see it implemented) not having a page bar at all for techniques. In mocking up that PR, I used this CSS: https://github.com/w3c/wcag-redesign/pull/33/files#diff-f6c1bcf8a240e8ffed6045cdf73c3b8917515902d26a525fc881fea16dbb63ca

Thoughts?

shawna-slh commented 2 years ago

looks like works on the All Techniques / index page, so I'm closing this issue image