Closed kfranqueiro closed 3 months ago
Name | Link |
---|---|
Latest commit | 407efdff937eb4058817cb47a97880976061c29e |
Latest deploy log | https://app.netlify.com/sites/wcag2/deploys/66b29235bf362d000822dd9a |
Deploy Preview | https://deploy-preview-3975--wcag2.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Could we make it stand out a bit more? Something along the lines of (but better looking) the note on the W3C's HTML 5 spec, for example. I'm not suggesting it be another fixed position box, it's more the fact that it stands out visually.
I would like to make it stand out a bit more. Will have a play.
kfranqueiro marked as non substantive for IPR from ash-nazg.
This is my suggested alternative. I do have the code but GitHub PRs of PRs is breaking me for the momet.
Includes:
title
Kevin sent me his changes (which are great, I was unaware of the CSS variables available in the W3C site's CSS) and I've integrated them with a couple of changes:
h2
rather than h3
(the latter would be skipping a heading level; I've intentionally avoided adding it to the table of contents though)_includes
files (which is great that it enables doing that - less work for Cheerio)Is there a reason not to use the WAI site component for Document Notes, e.g., Deprecated? (Here's an implementation of Archived.)
We can create one for Obsolete.
We can also update the component visual design and other if we deem that best.
The component currently adds the note type to the <title>
, which I think is important.
Perhaps it should also be in the h1? — it's there visually but I think not programmatically.
(Oops, missed the link to 'deprecated' - some of the below still applies)
Was thinking about the approach that I took before seeing the Archive component. This what was I had in mind when creating the Obsolete approach:
The Archived component does some of one, none of two and some of three.
The obsolete box is that bit more salient: whole block colour, stronger block heading style. Arguable whether red or yellow is more visually salient, that may be much more of a preference. One thing I did play about with was including an icon to make it even stronger as a warning.
I included a left hand border as something to try to hint at there being something different about this page. Bars like this are are a relatively common way to link together content (for example GDS error message component) although I would struggle to find a pattern where it is used full page.
Finally, Obsolete pages includes content in the <title>
. I am not sure it also needs it in the <h1>
. I played with it a bit but it started to become a bit cluttered visually and I am assuming this would be similarly cluttered for screen reader users.
Broadly speaking I think there is a need for a component that is stronger than archived. Archived content may still have some interest within it, Obsolete content should not be used. These are slightly different points.
I am fine with going with the EO deprecated style for the obsolete, but also think Kevin's comments about a visual distinction have merit. Either is an improvement on current, and either would be satisfactory IMO.
Just my first impression opinion, this is all moving in the right direction and an improvement. Thank you Shawn and Keven and EO.
Is there a reason not to use the WAI site component for Document Notes, e.g., Deprecated? (Here's an implementation of Archived.)
+1 to deprecated component, -1 to archived component.
@kfranqueiro what is the plan for 2.1 and 4.1.1 Techniques?. I am of the opinion they should also be flagged as Obsolete.
This failure relates to 4.1.1: Parsing, and should be considered as always satisfied for any content using HTML or XML. This Success Criterion was removed in WCAG 2.2.
@kfranqueiro what is the plan for 2.1 and 4.1.1 Techniques?. I am of the opinion they should also be flagged as Obsolete.
@bruce-usab I marked them as obsoleteSince: 22
, which would not flag them as obsolete in 2.1, since the SC wasn't removed until 2.2. If we really feel strongly, that can be tweaked by changing obsoleteSince
in the 4.1.1-related techniques in this PR.
This property has no effect on message content, only on whether the message is rendered or not, depending on the version being built.
(Note that the majority of 2.1-specific support for the Eleventy build system will be in a separate PR after this gets merged.)
Replying to @bruce-usab:
Can we find a disclaimer on Adobe.com wrt Flash being unsupported to link to? (And to something similar for Silverlight?)
I've now added links to end-of-life articles regarding both.
For the technique using summary attribute on tables, please mention the version or year the attribute was dropped from HTML.
I added a change to reflect that summary
has been obsolete since HTML5 (as per the differences document published in 2014; the decision to remove it seems to date back as early as 2011).
I'm curious as to why this was requested for this specific attribute?
From backlog call today, I aspire to offer some additional text for the explanations of why obsoleted for the few that (like summary) just have the statement that XYZ is obsolete.
@bruce-usab If you open that up as a separate PR
This PR supersedes #3961; it accomplishes the same output, plus resolves a leftover empty section remaining in that PR.
Related issues: #3651, #3758
Note to WG
I would appreciate eyes on
obsoleteMessage
wording, seen at the end of each technique's About box (or at the top of HTML files in this PR) for restored obsolete techniques:You don't need to worry about the implementation parts of the PR (unless you want to); I expect to ask @iadawn to review that part.
Background
Historically, techniques have been removed from this repository when they become obsolete. However, they are not removed from the WAI site in order to avoid link rot. This is not ideal, as it leaves those pages in isolation with no indication of being obsolete (with the exception of Flash and Silverlight pages, which had a message added by the build process).
Summary
This PR adds support for marking techniques as obsolete via front-matter. When a technique is marked as obsolete, it has the following effects:
This PR also adds considerations for WCAG 2.2's obsolete SC, 4.1.1 Parsing:
Changes
obsoleteSince
- indicates version upon which the technique became obsolete (in XY notation e.g.22
)obsoleteMessage
- Message to display in About this Technique boxobsoleteSince
andobsoleteMessage
setExclusions
There are 2 techniques I have not restored; if folks have suggestions on wording for
obsoleteMessage
for them, I can add them:Note: XSLT build system deprecation
This PR introduces front-matter in some HTML files, which the previous XSLT build system won't know how to handle. Now that we have the Eleventy build system in use for WAI site updates as well as gh-pages deploys, there should be no further dependencies on it, and I plan to remove it and think about updating the main README (update: in #3985).