search

w3c / web-annotation

Web Annotation Working Group repository, see README for links to specs
https://w3c.github.io/web-annotation/
Other
141 stars 30 forks source link

If-Match not used in PUT protocol test #386

Closed azaroth42 closed 7 years ago

azaroth42 commented 7 years ago

The test that checks whether an annotation can be updated using PUT doesn't send If-Match, and hence a server that respects the SHOULD in the second paragraph of https://www.w3.org/TR/annotation-protocol/#update-an-existing-annotation will fail the request, and thus fail the test.

Can we improve the test to first do a GET on the annotation URI, check for the ETag and then send the correct If-Match header?

halindrome commented 7 years ago

I will fix this today.

halindrome commented 7 years ago

I have updated the server tests to use this. Note that it will probably BREAK other implementations that were passing because we are now requiring an additional header that needs to be in the CORS permissions.

iherman commented 7 years ago

@azaroth42 @BigBlueHat I will close this specific issue, but you should look at the implementation issues raised by @halindrome ASAP...