Closed inexorabletash closed 1 year ago
@asutherland, @saschanaz, @mkruisselbrink - I'd appreciate your feedback here.
The text "There is an equivalence between the following..." and associated Issue may be removable now.
Replace lock set and request queue associations with an origin with a lock manager instead
This better matches the current Gecko implementation, can we do it in a separate PR to make this one shorter?
Replace lock set and request queue associations with an origin with a lock manager instead
This better matches the current Gecko implementation, can we do it in a separate PR to make this one shorter?
SGTM!
Cool, are you willing to do it or should I go ahead?
Cool, are you willing to do it or should I go ahead?
I'm sure you'll get to it before I will!
FYI, c/o a bunch of refactorings (thanks @saschanaz for PRs and reviews!) this PR is now a much more minimal change. I haven't actually updated any of the relevant parts about bottles/buckets/etc based on discussion above, though.
ObSeuss:
I need to get more familiar with the storage spec to fully understand this one, so for now I think @annevk is still the best person to review this.
Updated - @saschanaz take a look?
Nominally, replace "origin" with "storage key". But practically speaking:
Some references to "storage bucket" are retained in prose where it seems to add value and is more correct than "origin".
Fixes #74
Preview | Diff
Preview | Diff