w3c / web-locks

Cross-tab resource coordination API
https://w3c.github.io/web-locks/
Other
124 stars 16 forks source link

Adopt terms from Storage spec #75

Closed inexorabletash closed 1 year ago

inexorabletash commented 3 years ago

Nominally, replace "origin" with "storage key". But practically speaking:

Some references to "storage bucket" are retained in prose where it seems to add value and is more correct than "origin".

Fixes #74


Preview | Diff


Preview | Diff

inexorabletash commented 3 years ago

@asutherland, @saschanaz, @mkruisselbrink - I'd appreciate your feedback here.

inexorabletash commented 3 years ago

The text "There is an equivalence between the following..." and associated Issue may be removable now.

saschanaz commented 2 years ago

Replace lock set and request queue associations with an origin with a lock manager instead

This better matches the current Gecko implementation, can we do it in a separate PR to make this one shorter?

inexorabletash commented 2 years ago

Replace lock set and request queue associations with an origin with a lock manager instead

This better matches the current Gecko implementation, can we do it in a separate PR to make this one shorter?

SGTM!

saschanaz commented 2 years ago

Cool, are you willing to do it or should I go ahead?

inexorabletash commented 2 years ago

Cool, are you willing to do it or should I go ahead?

I'm sure you'll get to it before I will!

inexorabletash commented 2 years ago

FYI, c/o a bunch of refactorings (thanks @saschanaz for PRs and reviews!) this PR is now a much more minimal change. I haven't actually updated any of the relevant parts about bottles/buckets/etc based on discussion above, though.

ObSeuss: image

saschanaz commented 2 years ago

I need to get more familiar with the storage spec to fully understand this one, so for now I think @annevk is still the best person to review this.

inexorabletash commented 1 year ago

Updated - @saschanaz take a look?