w3c / web-share-target

Web API proposal for receiving shared data
https://w3c.github.io/web-share-target/
Other
191 stars 20 forks source link

Character encoding for example page #66

Closed ewilligers closed 6 years ago

ewilligers commented 6 years ago

This PR is to test PR preview.

mgiuca commented 6 years ago

Nope, still doesn't seem to work.

See tobie/pr-preview#20 where we thought it was fixed.

marcoscaceres commented 6 years ago

Weird... I swear I saw it work in the other PR. Might need to try with an empty commit ?

marcoscaceres commented 6 years ago

Oh, this page is not targeted by .pr_preview, only "src_file": "index.html" is.

mgiuca commented 6 years ago

Oh, d'oh, this one was changing a different index.html. My mistake.

Yeah, pr-preview only affects changes to the spec.

We can close this out, unless you actually want to land the encoding change, @ericwilligers ? In which case, change the description.

ewilligers commented 6 years ago

PR Preview is working.