Add "validate share data" algorithm

w3c / web-share

Web API proposal for sharing data from a web page

https://www.w3.org/TR/web-share/

Other

353 stars 65 forks source link

Add "validate share data" algorithm #185

Closed marcoscaceres closed 3 years ago

marcoscaceres commented 4 years ago

This keeps the good parts we derived from "canShare()".

For normative changes, the following tasks have been completed:

[x] Modified Web platform tests. The other parts are already tested.

Implementation commitment:

[x] WebKit
[x] Chromium
[ ] Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=)

Preview | Diff

marcoscaceres commented 4 years ago

@ericwilligers, @mgiuca, I think this is still useful to merge as a basis on which to build the things we discussed during the call. It's mostly just a refactor based on @inexorabletash suggestions.

marcoscaceres commented 3 years ago

Ok, my intent it to merge this tomorrow as it matches Chrome/WebKit's behavior.

We can then continue with #177 and figuring out #178.

saschanaz commented 3 years ago

Okay, thanks for https://github.com/web-platform-tests/wpt/pull/30046.

marcoscaceres commented 3 years ago

Okay, thanks for web-platform-tests/wpt#30046.

No problem. Do you want to review those too by chance?