Editorial: use global task to resolve promises

marcoscaceres commented 2 years ago

Closes #235

Editorial fix-up of what we originally intended. Doesn't affect UA behavior is and shouldn't be observable/testable (AFAIK).

:boom: Error: 500 Internal Server Error :boom:

PR Preview failed to build. (Last tried on May 27, 2022, 7:07 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [Spec Generator](https://www.w3.org/2015/labs/) - Spec Generator is the web service used to build specs that rely on ReSpec. :link: [Related URL](https://labs.w3.org/spec-generator/?type=respec&url=https%3A%2F%2Fraw.githubusercontent.com%2Fw3c%2Fweb-share%2Fc1e3ac98a686aa46f3fd9fdb59ba9c6ed871da8a%2Findex.html%3FisPreview%3Dtrue) ``` 📡 HTTP Error 404: http://labs.w3.org/spec-generator/uploads/flncu8 ``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20w3c/web-share%23236.)._

marcoscaceres commented 2 years ago

Thanks for reviewing it @ewilligers 🙏

marcoscaceres commented 2 years ago

Taking as is... @annevk, please let us know if we missed anything.

annevk commented 2 years ago

This looks good. State changes after reject/resolve are okay here as when script runs the state changes will have been made, though if you ever do something else in these tasks you want to be careful that does not change. (E.g., if you start dispatching events you need to make the state changes first.)

marcoscaceres commented 2 years ago

Appreciate the guidance, @annevk! will keep an eye our for this also in other specs (already spotted the same issue a few times in Payment Request!).

w3c / web-share

Editorial: use global task to resolve promises #236

:boom: Error: 500 Internal Server Error :boom: