search

w3c / web-share

Web API proposal for sharing data from a web page
https://www.w3.org/TR/web-share/
Other
353 stars 65 forks source link

What's the scope of "abort these steps"? #266

Closed chaals closed 1 year ago

chaals commented 1 year ago

In various subsections of the algorithm that defines the implementation of the share method there is the instruction

abort these steps.

However, it is unclear whether the steps referred to are those in the "subroutine" (and in each case in this algorithm the instruction is within a "subroutine" conditionally entered) or those of the algorithm as a whole.

Perhaps "terminate the algorithm" or something similar would be clearer language?

marcoscaceres commented 1 year ago

Yeah, should probably switch to terminate this algorithm.

hober commented 1 year ago

Maybe an issue should be raised against Infra to define a phrase to use?

chaals commented 1 year ago

@hober done: https://github.com/whatwg/infra/issues/527

marcoscaceres commented 1 year ago

@chaals, sent https://github.com/w3c/web-share/pull/268 ... can you please take a look and approve for record keeping purposes.

Thanks in advance!!!