search

w3c / webappsec-credential-management

WebAppSec Credential Management
https://w3c.github.io/webappsec-credential-management/
Other
50 stars 38 forks source link

Add support for publickey-credentials-create permission policy #209

Closed stephenmcgruer closed 1 year ago

stephenmcgruer commented 2 years ago

This PR adds support for publickey-credentials-create permission policy, to support https://github.com/w3c/webauthn/pull/1801

See also https://github.com/w3c/webauthn/issues/1656

Preview | Diff

stephenmcgruer commented 2 years ago

(I believe the build fails because the corresponding WebAuthn PR is not landed, so the dfn reference isn't there yet)

stephenmcgruer commented 2 years ago

cc @ve7jtb , who I believe wished to make sure that this was compatible with the previous L2 discussion on what create() in a cross-origin iframe would look like (particularly the permission policy name, I believe).

aaahlam621997 commented 1 year ago

يضيف هذا PR دعما لسياسة الأذونات ، لدعم w3c / webauthn # 1801publickey-credentials-create

انظر أيضا w3c/webauthn#1656

معاينة | فرق

stephenmcgruer commented 1 year ago

(Closing/opening just to kick the CI into re-running)

stephenmcgruer commented 1 year ago

So the CI is broken because the navigation re-write in HTML (https://github.com/whatwg/html/pull/6315) un-exported the concept of a parent browsing context, and so the entire webappsec-credential-management spec will no longer build. Guidance from HTML folks is that the spec should be talking in terms of Navigables instead of browsing contexts, which I don't immediately understand very well 🤣

This is not related to this PR, so my suggestion is that we ignore the failing CI here and open an issue to track the failing build - wdyt @nsatragno ?

nsatragno commented 1 year ago

SGTM