search

w3c / webappsec-mixed-content

WebAppSec Mixed Content
https://w3c.github.io/webappsec-mixed-content/
Other
12 stars 22 forks source link

Include concepts from MIX in MIX2 #30

Closed carlosjoan91 closed 4 years ago

carlosjoan91 commented 4 years ago

This incorporates the suggestions in https://github.com/w3c/webappsec-mixed-content/issues/25 to merge MIX onto MIX2, so MIX2 can completely replace it.

annevk commented 4 years ago

What would make this easier to review if we had a diff between MIX and MIX2 (done in the way you did here) using https://services.w3.org/htmldiff.

carlosjoan91 commented 4 years ago

Diff is attached. I can also add it as a file on the PR, but I'm not sure it would make sense for it to live on the repository, let me know if you'd prefer that though. diff.zip

annevk commented 4 years ago

That's a diff of the source, not the generated output, right?

carlosjoan91 commented 4 years ago

Yeah, sorry that was not intended, the proper one is this one.

annevk commented 4 years ago

Thank you, this largely looks like an improvement to me and I can think any further issues are best discussed after this is done. One thing that seems problematic though is the omission of the Acknowledgments section. Ideally those only ever grow.

carlosjoan91 commented 4 years ago

Thanks for reviewing. I went ahead and copied/slightly updated the acknowledgements from MIX since they are still valid on this version. Happy to keep adding/updating as needed.

annevk commented 4 years ago

Looks good to me. @estark37 or @mikewest should probably do a final pass.

carlosjoan91 commented 4 years ago

@mikewest: Assigned to you for a final pass (since @estark37 already did the initial review round). Can you please take a look? Thanks

mikewest commented 4 years ago

I tried to get to this today, and failed. It's top of my list for the morning (even on my calendar!). Apologies for the delay. :(