search

w3c / webappsec-permissions-policy

A mechanism to selectively enable and disable browser features and APIs
https://w3c.github.io/webappsec-permissions-policy/
Other
398 stars 155 forks source link

unsigned long? lineNumber and columnNumber in FeaturePolicyViolationReportBody #224

Open bakulf opened 6 years ago

bakulf commented 6 years ago

Spec says that lineNumber and columnNumber in FeaturePolicyViolationReportBody interface are "long?". They should be "unsigned long?" to be consistent with DeprecationReportBody and InterventionReportBody from Reporting API.

annevk commented 6 years ago

And they should be called lineno and colno to be consistent with ErrorEvent...

See also https://github.com/w3c/webappsec-csp/issues/268.

clelland commented 6 years ago

Those fields are still called lineNumber and columnNumber in https://w3c.github.io/webappsec-csp/#violation-events -- I think we should ensure that the reporting API report bodies are more-or-less consistent with each other, as opposed to making one of them different to match an HTML interface.

(No problem changing it, I'd just want to be sure that people are on board with changing Deprecation, Intervention and CSP Violation events as well)

annevk commented 6 years ago

cc @andypaicu

andypaicu commented 6 years ago

Yes when it comes to CSP the names should be lineno and colno

clelland commented 6 years ago

Also cc @dcreager @paulmeyer90 for the reporting API

paulmeyer90 commented 6 years ago

I also think it makes more sense for the names to be consistent with the other report types, and both deprecation and intervention reports are already shipped. I'd be in favor of keeping them the same.