Link to more rigorous definitions

w3c / webappsec-permissions-policy

A mechanism to selectively enable and disable browser features and APIs

https://w3c.github.io/webappsec-permissions-policy/

Other

399 stars 155 forks source link

Link to more rigorous definitions #511

Closed domfarolino closed 1 year ago

domfarolino commented 1 year ago

This PR cleans up various parts of the Permissions Policy standard by:

Formalizing links to various definitions such as [=Document/origin=], plenty of https://infra.spec.whatwg.org/ concepts, and internal definitions that we're linked to. This is perhaps most of this PR.
Gives to formal members the permissions policy struct, namely the inherited policy and declared policy, whose "type" are the definitions of the same name that are not for="" anything. This makes it much more clear which every instance of an IP or DP belong to, etc.

This also fixes #489.

Preview | Diff

domfarolino commented 1 year ago

Oops, I left this as a draft since I had a few questions/nits to make but am mostly OOO-ish this week. I'll address the above soon and maybe put some more comments myself.

domfarolino commented 1 year ago

Hey Ian, please look specifically at the last commit where I actually remove the top-level definitions of "inherited policy" and "declared policy" altogether, in favor of the definitions that are for="permissions policy" specifically. This resulted in removing the Declared policies section altogether, however I left the inherited one alone, since it exports the definition https://w3c.github.io/webappsec-permissions-policy/#inherited-policy-for-a-feature that is not redundant with the for="permissions-policy" definitions.

domfarolino commented 1 year ago

Ping @clelland

domfarolino commented 1 year ago

OK it looks like there are only two outstanding comments at this point, which could use your input:

domfarolino commented 1 year ago

OK I think this should just about be ready % one question about a comment.