w3c / webauthn

Web Authentication: An API for accessing Public Key Credentials
https://w3c.github.io/webauthn/
Other
1.19k stars 172 forks source link

[[Get]] method doesn't exist in CredMan #2169

Closed emlun closed 1 week ago

emlun commented 1 month ago

§5.1.4. Use an Existing Credential to Make an Assertion - PublicKeyCredential’s [[Get]](options) Method appears to reference a [[Get]] internal method on the Credential interface from CredMan, but no such internal method exists (unlike [[Create]], which does exist). Rather, [[DiscoverFromExternalSource]] is the actual internal method we override.

Proposed Change

emlun commented 1 month ago

The [[Get]] was added in commit 46d6c51d7908a0f879c32586d3a09a4ccf1ee903 in PR #672. The reason appears to have been for consistency with §5.1.3. Create a New Credential - PublicKeyCredential’s [[Create]](origin, options, sameOriginWithAncestors) Method. "Use an existing credential to make an assertion" already had a "[[DiscoverFromExternalSource]]" sub-heading; the reason this was (and still is) a sub-heading appears to be because "Use an existing credential to make an assertion" refers to both [[DiscoverFromExternalSource]] and [[CollectFromCredentialStore]] and how they interact.

emlun commented 1 month ago

2024-10-02 WG call: hearing no objections to this. @emlun to open a PR.

emlun commented 1 week ago

Fixed in PR #2180.