Add AbortError or EncodingError exception as argument for rejected flush() promises

w3c / webcodecs

WebCodecs is a flexible web API for encoding and decoding audio and video.

https://w3c.github.io/webcodecs/

Other

971 stars 136 forks source link

Add AbortError or EncodingError exception as argument for rejected flush() promises #188

Closed chcunningham closed 3 years ago

chcunningham commented 3 years ago

Alligns with how promises are rejected in the ImageDecoder proposal (https://github.com/w3c/webcodecs/pull/152)

Saying why the promise was rejected seems helpful. Not strictly necessary, since they may know why via other means (e.g. EncodingError would also be fired via the error callback).

chcunningham commented 3 years ago

Triage note: marking 'breaking' as this changes what a promise is rejected with. Having said that, the break is very minor (most folks will probably ignore this value).