search

w3c / webcodecs

WebCodecs is a flexible web API for encoding and decoding audio and video.
https://w3c.github.io/webcodecs/
Other
978 stars 136 forks source link

[WebCodecs] Fix markup for notes within lists #477

Closed tidoust closed 2 years ago

tidoust commented 2 years ago

A <div> cannot appear within a <dl>. Bikeshed used to automatically tie notes with the previous <dd> in a list but no longer does that, and generated HTML is now invalid.

Preview | Diff

tidoust commented 2 years ago

Note CI test failure on OPUS spec is expected. Fixed by #476.

chcunningham commented 2 years ago

Thanks @tidoust. Looks like the opus check is still failing. I wasn't able to quickly determine the cause. Did you miss one?

padenot commented 2 years ago

Maybe it simply needs to be rebased.

tidoust commented 2 years ago

Maybe it simply needs to be rebased.

Yes, CI tests start from the state of the repo at the time the PR was made (and thus could not see fix in #476). I rebased the PR.

padenot commented 2 years ago

Thanks for rebasing, merging now.