search

w3c / webcodecs

WebCodecs is a flexible web API for encoding and decoding audio and video.
https://w3c.github.io/webcodecs/
Other
953 stars 135 forks source link

Add a way of specifying blockSize and compressLevel to FLAC encod… #620

Closed bdrtc closed 1 year ago

bdrtc commented 1 year ago

This PR adds blockSize, compressLevel configuration knobs to the FLAC encoder.

This should fix #595 , @Yahweasel @dalecurtis

bdrtc commented 1 year ago

@padenot @aboba .

bdrtc commented 1 year ago

Do any reviewers have further comments here ? Thanks for your time 🥇

Yahweasel commented 1 year ago

Do any reviewers have further comments here ? Thanks for your time 1st_place_medal

I have none. Works for me.

dalecurtis commented 1 year ago

@chrisn did you want to stamp and merge?

chrisn commented 1 year ago

There's just one change remaining, I suggest removing the FLAC-DRAFT reference and updating FLAC to point to the IETF draft.

bdrtc commented 1 year ago

There's just one change remaining, I suggest removing the FLAC-DRAFT reference and updating FLAC to point to the IETF draft.

done, update FLAC reference to IETF draft. @chrisn