Closed bdrtc closed 1 year ago
Do we want a config level bitrate mode knob like we have for video instead?
I agree with @dalecurtis, bitrate mode seems like a very generic knob that will be used for many codecs with the same meaning. So I think it belongs in AudioEncoderConfig
AudioEncoderConfig
Thanks feedback, I considered add this to AudioEncoderConfig before commit, but for audio codec, not all codecs support vbr mode, For example ulaw/alaw, what will happen if user specify a bitrate mode to AudioEncoderConfig that current codec does't supported ?
what will happen if user specify a bitrate mode to AudioEncoderConfig that current codec does't supported ?
AudioEncoder.isConfigSupported() will return false.
Do we want a config level bitrate mode knob like we have for video instead?
I will move it to AudioEncoderConfig
and add a Note, Thanks.
Dear editors, any more comments about this ? thanks.
LGTM @tguilbert-google please take a look
Also LGTM!
Also LGTM!
Thanks. If there's any questions please let me know when you approve this.
fixes #649
Preview | Diff