search

w3c / webcodecs

WebCodecs is a flexible web API for encoding and decoding audio and video.
https://w3c.github.io/webcodecs/
Other
941 stars 132 forks source link

Need to make dictionary members more consistent in coding style? #658

Closed helaozhao closed 1 year ago

helaozhao commented 1 year ago

just as the members in opus-encoder-config. There's a kind of style of CamelCase, such as frameDuration, and a kind of style of flatcase as well.

Does there still have an opportunity to make them consistent, like in camel case?

tidoust commented 1 year ago

Thanks for the report. Closing as duplicate as I think this is being tracked in #588. Feel free to reopen (or complete #588) if I missed something!

helaozhao commented 1 year ago

Thanks for the report. Closing as duplicate as I think this is being tracked in #588. Feel free to reopen (or complete #588) if I missed something!

I think there is a little different in that #588 mainly discusses the attribute bitrate, and it looks that there has got an agreement ( bitrate is proper in style). In this issue I referred to the attributes in opus-encoder-config, especially the attributes of packetlossperc and useinbandfec. It's great if has chance to change them.

chrisn commented 1 year ago

These opus attributes were previously discussed here: https://github.com/w3c/webcodecs/pull/594/files/f133d9401d90191f7de543cadfe0b3ae8acf2b42#r1001142719

Personally, I would prefer packetLossPerc, useInbandFec, useDtx (or should that be useInbandFEC and useDTX, following suggested casing rules?) But that said, an argument was also made for being consistent with ORTC.

bdrtc commented 1 year ago

one question: as w3c spec, we should follow the casing-rules of w3c or follow special codec RFC ? I prefer follow w3c design principles personally.