w3c / webdriver-bidi

Bidirectional WebDriver protocol for browser automation
https://w3c.github.io/webdriver-bidi/
353 stars 39 forks source link

Add `browsingContext.SetViewport` to commands #474

Closed jrandolf-2 closed 1 year ago

jrandolf-2 commented 1 year ago

Preview | Diff

thiagowfx commented 1 year ago

We really need some CI in this repo, so many things missed :-(

whimboo commented 1 year ago

We really need some CI in this repo, so many things missed :-(

I wonder if the parser can actually find un-referenced definitions and warn / error out. This would be helpful yes.

jrandolf-2 commented 1 year ago

We really need some CI in this repo, so many things missed :-(

I wonder if the parser can actually find un-referenced definitions and warn / error out. This would be helpful yes.

Not really feasible. We would need entry points to understand all un-referenced definitions. In any case, the reason I find so many errors is because while implementing chromium-bidi, we end up using all the types, so we see TypeScript failures if there is anything missing.