w3c / webdriver-bidi

Bidirectional WebDriver protocol for browser automation
https://w3c.github.io/webdriver-bidi/
353 stars 39 forks source link

Use `script.LocalValue` for arguments and `this` #477

Closed jrandolf-2 closed 1 year ago

jrandolf-2 commented 1 year ago

According to the steps, script.LocalValue must include script.RemoteReference and script.ChannelValue. A priori, there is no purpose in script.ArgumentValue


Preview | Diff

jrandolf-2 commented 1 year ago

I think adding all these types to local-cddl is wrong; I don't think clients ever have to parse these values.

Sure, but CDDL complains about unknown types if you don't include it because LocalValue references it and LocalValue exists in local-cddl.

jrandolf-2 commented 1 year ago

As discussed offline, the solution is to just make script.LocalValue only defined in remote.cddl.