Fix missing components in pattern patterns and default search value for string pattern

w3c / webdriver-bidi

Bidirectional WebDriver protocol for browser automation

https://w3c.github.io/webdriver-bidi/

351 stars 38 forks source link

Fix missing components in pattern patterns and default search value for string pattern #513

Closed juliandescottes closed 11 months ago

juliandescottes commented 1 year ago

Fixes #507.

Attempts to fix a few issues:

when no value is provided for protocol, pathname or search in a URLPatternPattern, we should not attempt to match against it
with a URLPatternString, the search component should default to empty string, not null

Preview | Diff

juliandescottes commented 1 year ago

I'll move to draft until @jgraham is back and can take a look.

juliandescottes commented 12 months ago

cc @jgraham for review

juliandescottes commented 11 months ago

Small review ping for @jgraham

juliandescottes commented 11 months ago

@thiagowfx maybe you want to take another look at this for a final review?

juliandescottes commented 11 months ago

Thanks for the review!

Are you planning to add WPT tests for these edge cases?

I tried to cover it already url_patterns_tentative.py (that's why we have the "tentative" suffix actually). Once this PR lands I will remove the suffix. That will happen downstream at the same time as I update our implementation to match the new spec: https://bugzilla.mozilla.org/show_bug.cgi?id=1849743