Closed juliandescottes closed 11 months ago
I'll move to draft until @jgraham is back and can take a look.
cc @jgraham for review
Small review ping for @jgraham
@thiagowfx maybe you want to take another look at this for a final review?
Thanks for the review!
Are you planning to add WPT tests for these edge cases?
I tried to cover it already url_patterns_tentative.py (that's why we have the "tentative" suffix actually). Once this PR lands I will remove the suffix. That will happen downstream at the same time as I update our implementation to match the new spec: https://bugzilla.mozilla.org/show_bug.cgi?id=1849743
Fixes #507.
Attempts to fix a few issues:
Preview | Diff