search

w3c / webdriver-bidi

Bidirectional WebDriver protocol for browser automation
https://w3c.github.io/webdriver-bidi/
351 stars 38 forks source link

add `defaultValue` to `browsingContext.UserPromptOpenedParameters` #521

Closed Lightning00Blade closed 11 months ago

Lightning00Blade commented 1 year ago

Adds defaultValue to the browsingContext.UserPromptOpenedParameters so user's know the default value that was provided to the window.prompt(message, defaultValue)

HTML spec patch can be found at https://github.com/whatwg/html/pull/9645

Preview | Diff

whimboo commented 1 year ago

We probably should wait a bit with landing until the HTML spec changes are approved?

whimboo commented 1 year ago

I saw that @domenic approved the HTML spec changes. Lets get it merged. Thanks!

whimboo commented 1 year ago

@Lightning00Blade actually are you going to provide wpt tests for that new feature? I would like to wait a bit with the landing.

whimboo commented 11 months ago

FYI https://github.com/web-platform-tests/wpt/pull/41814 covers the test addition.

whimboo commented 11 months ago

Given that the test is being worked on and close to landing, we can already get this PR merged. Thanks for the work @Lightning00Blade!