search

w3c / webdriver-bidi

Bidirectional WebDriver protocol for browser automation
https://w3c.github.io/webdriver-bidi/
351 stars 38 forks source link

Add file dialog events and methods #535

Closed jrandolf closed 10 months ago

jrandolf commented 11 months ago

494

Preview | Diff

OrKoN commented 11 months ago

We are going to review internally first.

jgraham commented 11 months ago

mention that the dialog is not blocking and it is automatically dismissed.

I'm actually not sure we agreed to that (maybe by default if you're subscribed to the events?) But we need some kind of per-session configuration that enables either auto-dissmiss or not depending on the use case.

jrandolf commented 11 months ago

mention that the dialog is not blocking and it is automatically dismissed.

I'm actually not sure we agreed to that (maybe by default if you're subscribed to the events?) But we need some kind of per-session configuration that enables either auto-dismiss or not depending on the use case.

I think @OrKoN meant that it is automatically dismissed when a session is subscribed to the event.

But we need some kind of per-session configuration that enables either auto-dismiss or not depending on the use case.

So if one session is subscribed to the interception event, other sessions cannot be not auto-dismiss for the same reason multiple users of the same browser cannot use the browser if any of the users is picking a file.

whimboo commented 10 months ago

@jrandolf could you maybe explain why this PR got closed?

jrandolf commented 10 months ago

@jrandolf could you maybe explain why this PR got closed?

I'll be separating this PR into smaller, more independent features.