Serialize entire browsing context tree for contextDestroyed events

w3c / webdriver-bidi

Bidirectional WebDriver protocol for browser automation

https://w3c.github.io/webdriver-bidi/

336 stars 35 forks source link

Serialize entire browsing context tree for contextDestroyed events #578

Closed jgraham closed 8 months ago

jgraham commented 8 months ago

When multiple navigables / contexts are destroyed at once we only emit a single event. To ensure that that the client gets information about every context that's destroyed, send the whole context tree in that event, rather than just the topmost context.

Closes https://github.com/w3c/webdriver-bidi/issues/573

Preview | Diff

thiagowfx commented 8 months ago

Closes https://github.com/w3c/webdriver-bidi/issues/573

I believe this only takes effect if it's in the first comment. At least, a tooltip only shows up for it when it is in the first comment.

whimboo commented 8 months ago

@lutien would you mind to update the tests while implementing it on our side? We have https://bugzilla.mozilla.org/show_bug.cgi?id=1860955 for it.