search

w3c / webdriver-bidi

Bidirectional WebDriver protocol for browser automation
https://w3c.github.io/webdriver-bidi/
336 stars 35 forks source link

Rename field in cookie representation #596

Closed jugglinmike closed 8 months ago

jugglinmike commented 8 months ago

From @sadym-chromium in gh-501:

I believe it's not too late for changing the BiDi's network.Cookie "expires" to "expiry" to align with WebDriver Classic.

WebDriver Classic uses "expiry" as the "JSON key" to represent the RFC 6265 field called "expiry-time" ^1. Rename the field in WebDriver BiDi's corresponding types to promote coherence and facilitate additional normative references to that specification.

Also, correct reference to RFC 6265 field. The RFC uses the name "expires" for the attribute in the Set-Cookie header--not the field of the cookie within the storage model.

Preview | Diff

jgraham commented 8 months ago

Looks like it wouldn't affect anything yet implemented in gecko: https://searchfox.org/mozilla-central/search?q=expires&path=remote%2Fwebdriver-bidi&case=false&regexp=false so this seems like a good time to make the change ;)