search

w3c / webdriver-bidi

Bidirectional WebDriver protocol for browser automation
https://w3c.github.io/webdriver-bidi/
336 stars 35 forks source link

Clarify `script.addPreloadScript` with duplicate `context` #620

Closed Lightning00Blade closed 6 months ago

Lightning00Blade commented 6 months ago

Closes #617.

Preview | Diff

whimboo commented 6 months ago

As I've mentioned on the issue I wonder if we should do the same for session.subscribe and session.unsubscribe as well given that those two methods suffer from the same issue.

sadym-chromium commented 6 months ago

As I've mentioned on the issue I wonder if we should do the same for session.subscribe and session.unsubscribe as well given that those two methods suffer from the same issue.

In I'm general agree with your proposal to fix the subscribe / unsubscribe as well, but let's split the changes.

Lightning00Blade commented 6 months ago

Agree that we should change it there as well so I would keep the issue open till then, but let's do it in separate PRs.

whimboo commented 6 months ago

@Lightning00Blade would you be so kind and add a wpt test for the multiple usage of context?

whimboo commented 6 months ago

@Lightning00Blade would you be so kind and add a wpt test for the multiple usage of context?

Err, this will actually be part of https://github.com/web-platform-tests/wpt/pull/41932.