search

w3c / webdriver-bidi

Bidirectional WebDriver protocol for browser automation
https://w3c.github.io/webdriver-bidi/
336 stars 35 forks source link

Revert "Force Rust cache for GitHub workflow to cddl version 0.9.1" #622

Closed whimboo closed 6 months ago

whimboo commented 6 months ago

This reverts commit 9ddaeb4ee371c843d96d8b94a3c1efe19e9e70a2 because a new cddl 0.9.4 release with the fix is out.

Preview | Diff

whimboo commented 6 months ago

With the upgraded cddl version we now get an error:

error: parser errors
    ┌─ input:698:8
    │
698 │ } .and script.RegExpLocalValue
    │        ^^^^^^^^^^^^^^^^^^^^^^^ missing definition for rule script.RegExpLocalValue
    ·
703 │ } .and script.DateLocalValue
    │        ^^^^^^^^^^^^^^^^^^^^^ missing definition for rule script.DateLocalValue

Error: "incremental parsing error"

@jrandolf do you have an idea what this could be? Otherwise if that needs more investigation maybe we can get this PR merged and a new issue filed to get this CDDL error fixed? @jgraham what do you think?

whimboo commented 6 months ago

We actually have to export more types for the local cddl to get this fixed.

whimboo commented 6 months ago

@jgraham or @jrandolf can you please review? Thanks.