Add a capability for returning the default user agent header value

w3c / webdriver-bidi

Bidirectional WebDriver protocol for browser automation

https://w3c.github.io/webdriver-bidi/

336 stars 35 forks source link

Add a capability for returning the default user agent header value #652

Closed OrKoN closed 3 months ago

OrKoN commented 4 months ago

This PR would allow client to get the original default User-Agent header value. In Puppeteer, it would allow supporting the Browser.userAgent() API.

Closes #446

Preview | Diff

OrKoN commented 4 months ago

@whimboo is there a requirement for that from the classic users?

jgraham commented 4 months ago

So, in detail, the proposal as specified here is that you'd get an additional capability if the implementation supports BiDi irrespective of whether BiDi is requested or enabled (I think that's different to what I said in the previous discussion).

I still think that doesn't make any sense, and we should just add the capability directly to classic.

OrKoN commented 4 months ago

@jgraham I see, that makes sense. I have opened a PR here https://github.com/w3c/webdriver/pull/1790