search

w3c / webdriver-bidi

Bidirectional WebDriver protocol for browser automation
https://w3c.github.io/webdriver-bidi/
336 stars 35 forks source link

Add an autofill module #706

Open yoavweiss opened 1 month ago

yoavweiss commented 1 month ago

This is a PR similar to https://github.com/w3c/webdriver/pull/1797, but on the BiDi side. It adds a save and trigger autofill commands.

/cc @sadym-chromium

Preview | Diff

yoavweiss commented 1 month ago

@jimevans - I thought that using a "should" language in "The [=user agent=] should [=autofill=] |element| and |element|'s [=form owner=], while taking into account the contents of |store|" would be enough to ensure that user agents that don't support autofill would still be compliant. I'm happy to add an explicit condition to that effect.

Is it dependent on the autofill portion of the HTML Living Standard? Is it expected that the property names in the autofill store for testing map must match the autofill field name tokens?

It does. I guess I didn't make this dependency explicit. I'll take a stab at that.

OrKoN commented 3 weeks ago

It looks like the preview has not been regenerated for some reason (I am still seeing the save command).

martinLechnerShopify commented 3 weeks ago

@OrKoN I've addressed all your comments, would you be able to give it another pass? Thanks in advance!

yoavweiss commented 2 weeks ago

/cc @galich - I'd love your thoughts on this :)

martinLechnerShopify commented 1 week ago

Hi @OrKoN , coming back from a 2-weeks vacation, I wanted to check in and see where we stand with this PR - is this ok to be merged, so we can move on to the implementation phase? Thanks in advance for a quick update!

OrKoN commented 5 days ago

@martinLechnerShopify we need the approval from other browser vendors as well to merge this