search

w3c / webdriver-bidi

Bidirectional WebDriver protocol for browser automation
https://w3c.github.io/webdriver-bidi/
336 stars 35 forks source link

Add validation for headers and method in network.continueRequest #711

Closed juliandescottes closed 1 month ago

juliandescottes commented 1 month ago

Fixes #707

Preview | Diff

juliandescottes commented 1 month ago

I have only updated the parameters for continueRequest here, once we agree on the general approach I can do the same for commands using similar parameters.

cc @jgraham @OrKoN

OrKoN commented 1 month ago

@Lightning00Blade could you please check how we validate headers and the method in CDP?

juliandescottes commented 1 month ago

@Lightning00Blade @OrKoN any concern or remark about this change? I'm close to landing the corresponding changes for Firefox for info.

juliandescottes commented 1 month ago

LGTM (we probably want header validation for the response methods as well=

Thanks, I'll follow up quickly with a PR for the response methods!