w3c / webdriver-bidi

Bidirectional WebDriver protocol for browser automation
https://w3c.github.io/webdriver-bidi/
378 stars 42 forks source link

Remove request field from network.Initiator #815

Closed juliandescottes closed 15 hours ago

juliandescottes commented 1 week ago

Just a follow up to my comment on https://github.com/w3c/webdriver-bidi/pull/813/files#r1843522432

By definition at the moment the initiator cannot be empty, because request id is always defined. I'm proposing to remove it, it doesn't sound useful. We also did not emit it in Firefox FWIW.

cc @jgraham


Preview | Diff

juliandescottes commented 1 week ago

I have the same build issue as other PRs, and which also affects the latest builds in the main branch

LINE 2049: No 'dfn' refs found for 'viewport' with spec 'css2'. <a bs-line-number="2049" data-link-spec="css2" data-link-type="dfn" data-lt="viewport">viewport</a>

Not sure how bikeshed the available definitions from external specs, I couldn't see any recent change for the css2 spec which would explain the regression.

whimboo commented 4 days ago

The problem was fixed. So please rebase and push again. Thanks.

juliandescottes commented 4 days ago

rebased. cc @whimboo do you want to review or approve?