w3c / webdriver

Remote control interface that enables introspection and control of user agents.
https://w3c.github.io/webdriver/
Other
676 stars 190 forks source link

Editorial: use proper cross-references for DOM, FileAPI and some of HTML. #1689

Closed Ms2ger closed 1 year ago

Ms2ger commented 1 year ago

Preview | Diff

w3cbot commented 1 year ago

Ms2ger marked as non substantive for IPR from ash-nazg.

whimboo commented 1 year ago

Note there is a build failure in CI: Error: Bad request - pnpm/action-setup@v2.2.2 is not allowed to be used in w3c/webdriver. Actions in this workflow must be: within a repository owned by w3c or created by GitHub. I assume something has changed to this dependency and is not related to this PR?

Ms2ger commented 1 year ago

Not intentionally, but https://github.com/w3c/spec-prod/pull/148 looks highly suspicious. CC @sidvishnoi

sidvishnoi commented 1 year ago

Indeed. spec-prod now uses pnpm. Please add pnpm/action-setup to actions allow list in repo settings.

If there's some specific reason to not use action-setup from pnpm org, let me know so I can look into alternate approaches to enable pnpm (maybe with Node.js experimental corepack feature).

I'll update release changelog to reflect this potential breaking change.